Update to Rust 1.82 #1990
Merged
Update to Rust 1.82 #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to Rust 1.82.
The main change is in the safety of the bindings with the JS.
After some thinking, it seems to me that all functions where the JS reads memory from the Rust are safe. Yes the JS might throw an exception for example if the pointer is out of range, but that's similar to a Rust panic and not something unsafe.
The functions where the JS writes to the Rust memory are, of course, unsafe. Calling
buffer_copy(0, rand::random())is a very bad idea.Work time: 30mn